refactor: merge lightning-custom-message into lightning crate#4386
refactor: merge lightning-custom-message into lightning crate#4386okekefrancis112 wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
I've assigned @joostjager as a reviewer! |
okekefrancis112
force-pushed
the
drop_crate
branch
2 times, most recently
from
d0ad0e4 to
a5a2d77
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4386 +/- ##
==========================================
- Coverage 86.03% 86.03% -0.01%
==========================================
Files 156 156
Lines 103002 102990 -12
Branches 103002 102990 -12
==========================================
- Hits 88620 88606 -14
- Misses 11873 11878 +5
+ Partials 2509 2506 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okekefrancis112
force-pushed
the
drop_crate
branch
from
527de10 to
d062514
Compare
|
🔔 1st Reminder Hey @joostjager! This PR has been waiting for your review. |
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
PR doesn't seem fully ready for review with ci retrigger commit.
I haven't dealt with this macro yet, but curious which users use it.
| @@ -1,23 +0,0 @@ | |||
| [package] | |||
| name = "lightning-custom-message" | |||
There was a problem hiding this comment.
There's also a reference in .gitignore
| fn handle_custom_message( | ||
| &self, msg: Self::CustomMessage, sender_node_id: $crate::bitcoin::secp256k1::PublicKey | ||
| ) -> Result<(), $crate::lightning::ln::msgs::LightningError> { | ||
| &self, msg: Self::CustomMessage, sender_node_id: bitcoin::secp256k1::PublicKey |
There was a problem hiding this comment.
Leaving out $crate might be a problem when this exported macro is used in other crates?
| cargo doc -p lightning-persister --quiet --document-private-items --features tokio | ||
|
|
||
| echo -e "\n\nTest Custom Message Macros" | ||
| cargo test -p lightning-custom-message --quiet --color always |
There was a problem hiding this comment.
Check q: I think the only testing were doc tests, that are now running as part of lightning?
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
Summary
Merges the
lightning-custom-messagecrate into the mainlightningcrate. Thelightning-custom-messagecrate was originally separated for MSRV reasons, but both crates now require Rust 1.75, making the separation unnecessary.Backwards Compatibility
The macro remains publicly exported and works identically. Users can now access it via:
Closes: #4198